COMMIT Clean up and expand slightly spec for Kernel#system using "sh" when shell characters are present. http://github.com/rubyspec/rubyspec/commit/7592275eac39562289976725f4dc2b992aa0ce69 =================================================================== +++ 20110711T041415Z @@ 15934 @@ - returns false when command execution fails - returns false when the command has a non-zero exit status - does not write to stderr when it can't find a command +- executes with `sh` if the command contains shell characters +- ignores SHELL env var and always uses `sh` - is a private method - expands shell variables when given a single string argument - does not expand shell variables when given multiples arguments @@ 38367 @@ - returns false when command execution fails - returns false when the command has a non-zero exit status - does not write to stderr when it can't find a command +- executes with `sh` if the command contains shell characters +- ignores SHELL env var and always uses `sh` - is a private method - expands shell variables when given a single string argument - does not expand shell variables when given multiples arguments @@ 42991 @@ ) An exception occurred during: Mock.verify_count Process.setrlimit and Process.getrlimit coerces arguments to Integers FAILED +Mock '# @value=4, @calls=0>' expected to receive 'to_int' at least 1 times but received it 0 times /var/lib/chkbuild/tmp/build/ruby-1.8.6-o3//mspec/lib/mspec/expectations/expectations.rb:15:in `fail_with' /var/lib/chkbuild/tmp/build/ruby-1.8.6-o3//mspec/lib/mspec/mocks/mock.rb:110:in `verify_count' @@ 56585 @@ ) ConditionVariable#broadcast releases all threads waiting in line for this resource ERROR +ThreadError: Thread#join: deadlock 0xf79c2540 - mutual join(0xf78c3348) /var/lib/chkbuild/tmp/build/ruby-1.8.6-o3//rubyspec/library/conditionvariable/broadcast_spec.rb:55:in `join' /var/lib/chkbuild/tmp/build/ruby-1.8.6-o3//rubyspec/library/conditionvariable/broadcast_spec.rb:55 /var/lib/chkbuild/tmp/build/ruby-1.8.6-o3//rubyspec/library/conditionvariable/broadcast_spec.rb:55:in `each' =================================================================== --- 20110709T041853Z @@ 15934 @@ - returns false when command execution fails - returns false when the command has a non-zero exit status - does not write to stderr when it can't find a command -- uses /bin/sh if freaky shit is in the command - is a private method - expands shell variables when given a single string argument - does not expand shell variables when given multiples arguments @@ 38366 @@ - returns false when command execution fails - returns false when the command has a non-zero exit status - does not write to stderr when it can't find a command -- uses /bin/sh if freaky shit is in the command - is a private method - expands shell variables when given a single string argument - does not expand shell variables when given multiples arguments @@ 42989 @@ ) An exception occurred during: Mock.verify_count Process.setrlimit and Process.getrlimit coerces arguments to Integers FAILED -Mock '# @value=18446744073709551615, @calls=0>' expected to receive 'to_int' at least 1 times but received it 0 times /var/lib/chkbuild/tmp/build/ruby-1.8.6-o3//mspec/lib/mspec/expectations/expectations.rb:15:in `fail_with' /var/lib/chkbuild/tmp/build/ruby-1.8.6-o3//mspec/lib/mspec/mocks/mock.rb:110:in `verify_count' @@ 56583 @@ ) ConditionVariable#broadcast releases all threads waiting in line for this resource ERROR -ThreadError: Thread#join: deadlock 0xf7f28538 - mutual join(0xf7e29310) /var/lib/chkbuild/tmp/build/ruby-1.8.6-o3//rubyspec/library/conditionvariable/broadcast_spec.rb:55:in `join' /var/lib/chkbuild/tmp/build/ruby-1.8.6-o3//rubyspec/library/conditionvariable/broadcast_spec.rb:55 /var/lib/chkbuild/tmp/build/ruby-1.8.6-o3//rubyspec/library/conditionvariable/broadcast_spec.rb:55:in `each'